Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to 6.10.1 #30404

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Feb 7, 2019

fixes #30317

Summary

Bumps Kibana's EUI version from 6.10.0 to 6.10.1

Bug fixes

  • Fixed EuiSuperDatePicker crashing with negative relative value (#1537)
  • Fixed EuiSuperDatePicker crashing with invalid start and end prop values (#1544)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch release and updating kibana.

lgtm
code review, tested that the version bump resolves the issue

screen shot 2019-02-07 at 9 36 02 am

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chandlerprall
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chandlerprall chandlerprall merged commit b47a92c into elastic:master Feb 7, 2019
@chandlerprall chandlerprall deleted the eui-6.10.1 branch February 7, 2019 22:01
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Feb 7, 2019
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Feb 7, 2019
chandlerprall added a commit that referenced this pull request Feb 8, 2019
chandlerprall added a commit that referenced this pull request Feb 8, 2019
lukeelmers pushed a commit to lukeelmers/kibana that referenced this pull request Feb 8, 2019
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Feb 9, 2019
chandlerprall added a commit that referenced this pull request Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana crashes with cannot read property 'isAfter' of undefined when user tries to set relative time on maps
3 participants